[ASYNCIFY] Run continuations under callUserCallback #26095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
asyncify_callUserCallback
branch
2 times, most recently
from
b559688 to
6122ec5
Compare
sbc100
force-pushed
the
asyncify_callUserCallback
branch
from
6122ec5 to
ee1f567
Compare
Collaborator
Author
|
This change is going to be useful / essential for the followup to #26019 where i hope to make all (most) asyncify usage in the JS library automatic/transparent. |
sbc100
force-pushed
the
asyncify_callUserCallback
branch
from
ee1f567 to
20d5e0b
Compare
kripken
reviewed
Jan 13, 2026
kripken
reviewed
Jan 13, 2026
sbc100
force-pushed
the
asyncify_callUserCallback
branch
2 times, most recently
from
257a6ad to
d354cfd
Compare
kripken
reviewed
Jan 14, 2026
sbc100
force-pushed
the
asyncify_callUserCallback
branch
from
d354cfd to
f157cef
Compare
sbc100
force-pushed
the
asyncify_callUserCallback
branch
from
f157cef to
fc6f5e6
Compare
sbc100
force-pushed
the
asyncify_callUserCallback
branch
from
fc6f5e6 to
02d48dd
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 15, 2026
The only function that remains that still uses `async: true` is `emscripten_fiber_swap`, and this is because it doesn't use handleSleep or handleAsync, so is not a candidate for `async: auto`. Followup to emscripten-core#26019 and emscripten-core#26095.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 15, 2026
The only function that remains that still uses `async: true` is `emscripten_fiber_swap`, and this is because it doesn't use handleSleep or handleAsync, so is not a candidate for `async: auto`. Followup to emscripten-core#26019 and emscripten-core#26095.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 15, 2026
The only function that remains that still uses `async: true` is `emscripten_fiber_swap`, and this is because it doesn't use handleSleep or handleAsync, so is not a candidate for `async: auto`. Followup to emscripten-core#26019 and emscripten-core#26095.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 15, 2026
The only function that remains that still uses `async: true` is `emscripten_fiber_swap`, and this is because it doesn't use handleSleep or handleAsync, so is not a candidate for `async: auto`. Followup to emscripten-core#26019 and emscripten-core#26095.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 15, 2026
The only function that remains that still uses `async: true` is `emscripten_fiber_swap`, and this is because it doesn't use handleSleep or handleAsync, so is not a candidate for `async: auto`. Followup to emscripten-core#26019 and emscripten-core#26095.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 16, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 16, 2026
This test throws exceptions from withing native code which causes the runtime to exit as the stack is unwound.
sbc100
added a commit
that referenced
this pull request
Jan 16, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 16, 2026
The only function that remains that still uses `async: true` is `emscripten_fiber_swap`, and this is because it doesn't use handleSleep or handleAsync, so is not a candidate for `async: auto`. Followup to emscripten-core#26019 and emscripten-core#26095.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, its up to each callsite to inject
callUserCallback(e.g. viasafeSetTimeoutvssetTimeout).Forgetting to do so can resulting in strange behaviour such as
exit()not work as expected when called from the continuation.